Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options: reclassify #51

Merged
merged 3 commits into from
Jun 19, 2024
Merged

options: reclassify #51

merged 3 commits into from
Jun 19, 2024

Conversation

arnetheduck
Copy link
Member

Several options were mistakenly classified as db options when in fact they are column family options - the C interface does not make this distinction and instead puts them all under one umbrella.

This PR updates options to use nim setter/getter properties allowing both read and write of most options - lots of options are exposed both for reading and writing, but hey, one could always add even more of them - there's certainly no lack!

Several options were mistakenly classified as db options when in fact
they are column family options - the C interface does not make this
distinction and instead puts them all under one umbrella.

This PR updates options to use nim setter/getter properties allowing
both read and write of most options - lots of options are exposed both
for reading and writing, but hey, one could always add _even more_ of
them - there's certainly no lack!
@arnetheduck arnetheduck merged commit d648b10 into master Jun 19, 2024
9 checks passed
@arnetheduck arnetheduck deleted the fix-options branch June 19, 2024 06:39
@arnetheduck arnetheduck mentioned this pull request Jun 26, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant